-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LedgerState.hs improvements #503
Conversation
59fa43b
to
f719722
Compare
f719722
to
d0e5be3
Compare
pattern ConwayLedgerState x = S (S (S (S (S (S (Z x)))))) | ||
|
||
encodeLedgerState :: | ||
Consensus.CardanoCodecConfig Consensus.StandardCrypto |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This type has in fact changed, but it was mostly confirmed by @carbolymer that these functions are probably dead/unused.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
d0e5be3
to
2e42f5b
Compare
I just re-signed the commits. Please @carbolymer or @Jimbo4350 set this PR to merge when ready |
Changelog
How to trust this PR
These are just renamings for type aliases to reduce cognitive load. The exposed API remains the same.
Checklist
New tests are added if needed and existing tests are updated. See Running tests for more details