Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

legacy query: remove constitution-hash option #515

Merged
merged 2 commits into from
Dec 11, 2023

Conversation

smelc
Copy link
Contributor

@smelc smelc commented Dec 11, 2023

Changelog

- description: |
    Remove the `constitution-hash` option from the non-conway versions of `query`
# uncomment types applicable to the change:
  type:
  # - feature        # introduces a new feature
  - breaking       # the API has changed in a breaking way
  # - compatible     # the API has changed but is non-breaking
  # - optimisation   # measurable performance improvements
  # - improvement    # QoL changes e.g. refactoring
  # - bugfix         # fixes a defect
  # - test           # fixes/modifies tests
  # - maintenance    # not directly related to the code
  # - release        # related to a new release preparation
  # - documentation  # change in code docs, haddocks...

Context

Fixes #503

How to trust this PR

Highlight important bits of the PR that will make the review faster. If there are commands the reviewer can run to observe the new behavior, describe them.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. See Running tests for more details
  • Self-reviewed the diff

@smelc smelc force-pushed the smelc/legacy-query-remove-constitution-hash branch 2 times, most recently from 63dc923 to 952bd5c Compare December 11, 2023 14:28
@smelc smelc marked this pull request as ready for review December 11, 2023 14:46
Copy link
Contributor

@Jimbo4350 Jimbo4350 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@smelc
Copy link
Contributor Author

smelc commented Dec 11, 2023

cc @CarlosLopezDeLara

@smelc smelc force-pushed the smelc/legacy-query-remove-constitution-hash branch from 952bd5c to a553194 Compare December 11, 2023 19:31
@smelc smelc added this pull request to the merge queue Dec 11, 2023
Merged via the queue into main with commit a8bedc5 Dec 11, 2023
19 checks passed
@smelc smelc deleted the smelc/legacy-query-remove-constitution-hash branch December 11, 2023 20:07
carlhammann added a commit that referenced this pull request Jan 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

legacy command query presents constitution-hash as an option, it should not.
2 participants