Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use AnyShelleyBasedEra in ScriptWitnessErrorReferenceScriptsNotSupportedInEra #535

Merged
merged 1 commit into from
Dec 29, 2023

Conversation

felix-lipski
Copy link
Contributor

@felix-lipski felix-lipski commented Dec 29, 2023

Changelog

- description: |
    use AnyShelleyBasedEra
# uncomment types applicable to the change:
  type:
  # - feature        # introduces a new feature
  # - breaking       # the API has changed in a breaking way
  # - compatible     # the API has changed but is non-breaking
  # - optimisation   # measurable performance improvements
  - improvement    # QoL changes e.g. refactoring
  # - bugfix         # fixes a defect
  # - test           # fixes/modifies tests
  # - maintenance    # not directly related to the code
  # - release        # related to a new release preparation
  # - documentation  # change in code docs, haddocks...

Context

Just removing a TODO in code

How to trust this PR

Highlight important bits of the PR that will make the review faster. If there are commands the reviewer can run to observe the new behavior, describe them.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. See Running tests for more details
  • Self-reviewed the diff

cardano-cli/src/Cardano/CLI/Read.hs Outdated Show resolved Hide resolved
@felix-lipski felix-lipski added this pull request to the merge queue Dec 29, 2023
Merged via the queue into main with commit 1059ef4 Dec 29, 2023
23 checks passed
@felix-lipski felix-lipski deleted the felix/any-shelley-based-era-in-read branch December 29, 2023 20:05
@@ -244,7 +244,7 @@ renderScriptWitnessError = \case
pretty file <> ": expected a script in the Plutus script language, " <>
"but it is actually using " <> pshow lang <> "."
ScriptWitnessErrorReferenceScriptsNotSupportedInEra anyEra ->
"Reference scripts not supported in era: " <> pretty anyEra
"Reference scripts not supported in era: " <> pshow anyEra
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should provide Pretty AnyShelleyBasedEra similarly to Pretty AnyCardanoEra and just use pretty instead of pshow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants