Make it build with ghc-9.8 #594
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erikd
requested review from
Jimbo4350,
newhoggy,
carbolymer,
kevinhammond and
disassembler
as code owners
erikd
force-pushed
the
erikd/ghc-9.8
branch
6 times, most recently
from
dc6ea2a to
0c50822
Compare
|
|
smelc
reviewed
Feb 8, 2024
| @@ -17,6 +17,7 @@ import Cardano.CLI.Types.Errors.StakePoolCmdError | |||
|
|
|||
| import Control.Exception (IOException) | |||
| import Data.Text (Text) | |||
| -- import Prettyprinter | |||
There was a problem hiding this comment.
Suggested change
| -- import Prettyprinter |
cardano-cli/src/Cardano/CLI/Types/Errors/GovernanceQueryError.hs
Outdated
Show resolved
Hide resolved
| @@ -12,6 +12,7 @@ import Cardano.Api.Pretty | |||
| import Cardano.CLI.Types.Errors.NodeEraMismatchError | |||
| import Ouroboros.Consensus.Cardano.Block (EraMismatch (..)) | |||
|
|
|||
| -- import Prettyprinter ((<+>)) | |||
There was a problem hiding this comment.
Suggested change
| -- import Prettyprinter ((<+>)) |
carbolymer
reviewed
Feb 8, 2024
carbolymer
reviewed
Feb 8, 2024
There was a problem hiding this comment.
Please apply comments from @smelc and update hackage index in flake.lock.
Jimbo4350
reviewed
Feb 8, 2024
Done! |
erikd
force-pushed
the
erikd/ghc-9.8
branch
5 times, most recently
from
46b9e1b to
a20a6b7
Compare
carbolymer
approved these changes
Feb 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog
Context
Make it build with ghc-9.8
How to trust this PR
Highlight important bits of the PR that will make the review faster. If there are commands the reviewer can run to observe the new behavior, describe them.
Checklist