Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make committee keys able to sign transactions #596

Merged
merged 2 commits into from
Feb 7, 2024

Conversation

smelc
Copy link
Contributor

@smelc smelc commented Feb 6, 2024

Changelog

- description: |
    Make committee keys able to sign transactions
# uncomment types applicable to the change:
  type:
  - feature        # introduces a new feature
  # - breaking       # the API has changed in a breaking way
  - compatible     # the API has changed but is non-breaking
  # - optimisation   # measurable performance improvements
  # - improvement    # QoL changes e.g. refactoring
  # - bugfix         # fixes a defect
  # - test           # fixes/modifies tests
  # - maintenance    # not directly related to the code
  # - release        # related to a new release preparation
  # - documentation  # change in code docs, haddocks...

Context

Fixes #586

How to trust this PR

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. See Running tests for more details
  • Self-reviewed the diff

@smelc smelc force-pushed the smelc/support-cc-extended-signing branch from c897fee to f472515 Compare February 7, 2024 10:39
@smelc smelc marked this pull request as ready for review February 7, 2024 14:43
@smelc smelc added this pull request to the merge queue Feb 7, 2024
Merged via the queue into main with commit a71f8ac Feb 7, 2024
16 checks passed
@smelc smelc deleted the smelc/support-cc-extended-signing branch February 7, 2024 16:00
@gitmachtl
Copy link
Contributor

This is not working:

#586 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cardano-cli cannot sign with ConstitutionalCommittee Cold/Hot ExtendedSigningKey_ed25519_bip32
3 participants