Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow an output file to be specified for query pool-state #635

Merged
merged 1 commit into from
Mar 6, 2024

Conversation

neilmayhew
Copy link
Contributor

Changelog

- description: |
    Allow an output file to be specified for the various versions of query pool-state
# uncomment types applicable to the change:
  type:
  # - feature        # introduces a new feature
  # - breaking       # the API has changed in a breaking way
  - compatible     # the API has changed but is non-breaking
  # - optimisation   # measurable performance improvements
  - improvement    # QoL changes e.g. refactoring
  # - bugfix         # fixes a defect
  # - test           # fixes/modifies tests
  # - maintenance    # not directly related to the code
  # - release        # related to a new release preparation
  # - documentation  # change in code docs, haddocks...

Context

No corresponding issue.

How to trust this PR

  • Most of the changed lines are in golden files.
  • Output logic was copied from other commands.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. See Running tests for more details
  • Self-reviewed the diff

Copy link
Contributor

@smelc smelc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving to avoid blocking, but please apply my suggestion 👍

Thanks for your neat contribution!

cardano-cli/src/Cardano/CLI/EraBased/Run/Query.hs Outdated Show resolved Hide resolved
@smelc
Copy link
Contributor

smelc commented Mar 6, 2024

@neilmayhew> @-tag me when you want to merge, in case you don't have the right to do so. I'll merge on your behalf.

@neilmayhew neilmayhew force-pushed the neilmayhew/pool-state-output-file branch from e0f8cc9 to 3ff6b3b Compare March 6, 2024 14:07
@neilmayhew
Copy link
Contributor Author

neilmayhew commented Mar 6, 2024

@neilmayhew> @-tag me when you want to merge, in case you don't have the right to do so. I'll merge on your behalf.

@smelc Thanks. I don't have the right.

@neilmayhew neilmayhew force-pushed the neilmayhew/pool-state-output-file branch from 3ff6b3b to ba4fb94 Compare March 6, 2024 14:10
@neilmayhew
Copy link
Contributor Author

Suggestion added, and rebased on main

@smelc smelc added this pull request to the merge queue Mar 6, 2024
Merged via the queue into main with commit b0ede7b Mar 6, 2024
17 checks passed
@smelc smelc deleted the neilmayhew/pool-state-output-file branch March 6, 2024 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants