Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix parallel create-testnet-data stdout contents test #640

Merged

Conversation

carbolymer
Copy link
Contributor

Changelog

- description: |
    Fix parallel `create-testnet-data` stdout contents test 
# uncomment types applicable to the change:
  type:
  # - feature        # introduces a new feature
  # - breaking       # the API has changed in a breaking way
  # - compatible     # the API has changed but is non-breaking
  # - optimisation   # measurable performance improvements
  # - improvement    # QoL changes e.g. refactoring
  # - bugfix         # fixes a defect
   - test           # fixes/modifies tests
  # - maintenance    # not directly related to the code
  # - release        # related to a new release preparation
  # - documentation  # change in code docs, haddocks...

Context

This PR fixes this test failure: https://github.com/IntersectMBO/cardano-cli/actions/runs/8201716507/job/22431021627?pr=637#step:14:59
Which got introduced in #637, which got accidentally merged.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. See Running tests for more details
  • Self-reviewed the diff

@carbolymer carbolymer force-pushed the mgalazyn/fix/fix-flaky-parallel-testnet-data-stdout branch from 79271d8 to 3378e1c Compare March 8, 2024 11:46
@carbolymer carbolymer force-pushed the mgalazyn/fix/fix-flaky-parallel-testnet-data-stdout branch from 3378e1c to f3d9e94 Compare March 8, 2024 11:49
@carbolymer carbolymer marked this pull request as ready for review March 8, 2024 11:52
@carbolymer carbolymer requested review from smelc and palas and removed request for smelc March 8, 2024 11:55
@carbolymer carbolymer added this pull request to the merge queue Mar 8, 2024
Merged via the queue into main with commit 3329895 Mar 8, 2024
18 checks passed
@carbolymer carbolymer deleted the mgalazyn/fix/fix-flaky-parallel-testnet-data-stdout branch March 8, 2024 13:23
Copy link
Contributor

@Jimbo4350 Jimbo4350 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍


deriving via (ShowOf FileSem) instance Pretty FileSem

-- | Create new file semaphore. Always use with @NOINLINE@ pragma! Example:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why always use with NOINLINE?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise GHC could inline the semaphore, and instead of one we could end up with multiple, different semaphores not communicating with each other. So the locking wouldn't work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants