create-testnet-data: fix that treasury could be unexpectedly negative #644
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smelc
force-pushed
the
smelc/fix-treasury-subtrahend
branch
from
d55c46d to
54052e3
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
smelc
force-pushed
the
smelc/fix-treasury-subtrahend
branch
from
54052e3 to
cdb4e93
Compare
smelc
force-pushed
the
smelc/fix-treasury-subtrahend
branch
from
cdb4e93 to
08c71fa
Compare
smelc
requested review from
Jimbo4350,
newhoggy,
carbolymer,
kevinhammond and
disassembler
as code owners
carbolymer
approved these changes
Mar 12, 2024
Jimbo4350
reviewed
Mar 27, 2024
| GenesisCmdDelegatedSupplyExceedsTotalSupply delegated total -> | ||
| "Provided delegated supply is " <> pretty delegated <> ", which is greater than the specified total supply: " <> pretty total <> "." <> | ||
| "This is incorrect: the delegated supply should be less or equal to the total supply." <> | ||
| " Note that the total supply can either come from --total-supply or from the default template. Please fix what you use." |
There was a problem hiding this comment.
Which one takes precedent? The template or the cli parser?
There was a problem hiding this comment.
@Jimbo4350> the template takes precedence 👍
| nonDelegCoin = getCoinForDistribution nonDelegCoinRaw | ||
| delegCoin = getCoinForDistribution delegCoinRaw | ||
|
|
||
| getCoinForDistribution :: Integer -> Natural |
There was a problem hiding this comment.
Hm. I don't like these hidden calculations. It is always better to be explicit.
There was a problem hiding this comment.
@Jimbo4350> note that it was like this before in create-staked.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog
Context
Fixes #643
How to trust this PR
I wanted to test that
cabal test cardano-testnetpassed oncardano-node, using this version ofcardano-cli; but it's not easy to do right now. Still I think this is safe.Checklist