Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Display redeemers in transaction view #664

Merged
merged 6 commits into from Mar 26, 2024
Merged

Display redeemers in transaction view #664

merged 6 commits into from Mar 26, 2024

Conversation

palas
Copy link
Contributor

@palas palas commented Mar 20, 2024 •
edited

Changelog

- description: |
    Add info about redeemers to output of `transaction view` command.
  type:
  - feature        # introduces a new feature

Context

It increases the amount of info displayed. It is only applicable to Shelley and after. It uses cborg-json to render the CBOR of the redeemer.

How to trust this PR

I would check:

  • That the approach makes sense overall.
  • That it makes sense to return null when it does and it looks right in the changed tests.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. See Running tests for more details
  • Self-reviewed the diff

@palas palas added the enhancement New feature or request label Mar 20, 2024
@palas palas self-assigned this Mar 20, 2024
@smelc
Copy link
Contributor

smelc commented Mar 20, 2024

LGTM but I'm not approving since I never manipulated nor cbor nor redeemers 😆

@palas palas marked this pull request as ready for review March 25, 2024 18:15
@palas palas requested a review from carbolymer March 25, 2024 18:15
@palas palas enabled auto-merge March 26, 2024 18:01
@palas palas added this pull request to the merge queue Mar 26, 2024
Merged via the queue into main with commit 669bbc8 Mar 26, 2024
17 checks passed
@palas palas deleted the show-redeemer branch March 26, 2024 19:07
Jimbo4350
Jimbo4350 reviewed Mar 27, 2024
View reviewed changes
Copy link
Contributor

@Jimbo4350 Jimbo4350 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

cardano-cli/src/Cardano/CLI/Types/MonadWarning.hs Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jimbo4350 Jimbo4350 Jimbo4350 left review comments

@carbolymer carbolymer carbolymer approved these changes

@newhoggy newhoggy Awaiting requested review from newhoggy newhoggy is a code owner

@kevinhammond kevinhammond Awaiting requested review from kevinhammond kevinhammond is a code owner

@disassembler disassembler Awaiting requested review from disassembler disassembler is a code owner

Assignees

@palas palas

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@palas @smelc @carbolymer @Jimbo4350