Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support querying drep-state by script hash #666

Merged
merged 1 commit into from
Mar 26, 2024
Merged

Support querying drep-state by script hash #666

merged 1 commit into from
Mar 26, 2024

Conversation

palas
Copy link
Contributor

@palas palas commented Mar 20, 2024 •
edited
Loading

Changelog

- description: |
    Add support for querying drep state and stake distribution by script hash
  type:
  - feature        # introduces a new feature

Context

Addresses this issue, and it also adds the flag to stake distribution because it was using the same code.

How to trust this PR

It is small, but probably check that the changes to the golden tests and see that the changes to the code make sense too. I just tested in sancho net and it seems to work, feel free to do the same.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. See Running tests for more details
  • Self-reviewed the diff

@palas palas linked an issue Mar 20, 2024 that may be closed by this pull request
expand cardano-cli conway query drep-state to also query by scripthash #621
Closed
@palas palas self-assigned this Mar 20, 2024
@palas palas added the enhancement New feature or request label Mar 20, 2024
@palas palas force-pushed the query-drep-state-by-scripthash branch 2 times, most recently from bb68b1a to 9b0c30b Compare March 25, 2024 18:58
@palas palas marked this pull request as ready for review March 25, 2024 19:01
@palas palas force-pushed the query-drep-state-by-scripthash branch from 9b0c30b to 22721be Compare March 25, 2024 20:32
@palas palas added this pull request to the merge queue Mar 26, 2024
Merged via the queue into main with commit 7592b24 Mar 26, 2024
18 checks passed
@palas palas deleted the query-drep-state-by-scripthash branch March 26, 2024 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carbolymer carbolymer carbolymer approved these changes

@Jimbo4350 Jimbo4350 Awaiting requested review from Jimbo4350

@newhoggy newhoggy Awaiting requested review from newhoggy

@kevinhammond kevinhammond Awaiting requested review from kevinhammond

@disassembler disassembler Awaiting requested review from disassembler

Assignees

@palas palas

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

expand cardano-cli conway query drep-state to also query by scripthash
2 participants
@palas @carbolymer