Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drep: registration-certificate, update-certificate: test anchors URLs of length > 64 and <= 128 #671

Merged
merged 1 commit into from
Mar 22, 2024

Conversation

smelc
Copy link
Contributor

@smelc smelc commented Mar 21, 2024

Changelog

- description: |
    drep: registration-certificate, update-certificate: test anchors URLs of length > 64 and <= 128
# uncomment types applicable to the change:
  type:
  # - feature        # introduces a new feature
  # - breaking       # the API has changed in a breaking way
  # - compatible     # the API has changed but is non-breaking
  # - optimisation   # measurable performance improvements
  # - improvement    # QoL changes e.g. refactoring
  # - bugfix         # fixes a defect
  - test           # fixes/modifies tests
  # - maintenance    # not directly related to the code
  # - release        # related to a new release preparation
  # - documentation  # change in code docs, haddocks...

Context

I wrote those tests to reproduce #552. We can't reproduce it anymore, but since the bug was there at some point, and I wrote the tests anyway; I though "let's merge them".

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. See Running tests for more details
  • Self-reviewed the diff

@smelc smelc force-pushed the smelc/fix-metadata-url-64-chars-limit branch from 98b0d86 to 51ce7e4 Compare March 21, 2024 16:35
@smelc smelc marked this pull request as ready for review March 21, 2024 16:36
@smelc smelc added this pull request to the merge queue Mar 22, 2024
Merged via the queue into main with commit e37a31a Mar 22, 2024
18 checks passed
@smelc smelc deleted the smelc/fix-metadata-url-64-chars-limit branch March 22, 2024 08:39
Copy link
Contributor

@Jimbo4350 Jimbo4350 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. However we should also test the failure case and we should use hedgehog generators to test the range of allowed URLs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants