Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Comments and indentation #682

Merged
merged 2 commits into from
Mar 27, 2024
Merged

Comments and indentation #682

merged 2 commits into from
Mar 27, 2024

Conversation

palas
Copy link
Contributor

@palas palas commented Mar 26, 2024 •
edited by carbolymer
Loading

Changelog

- description: |
    Added comments and fixed layout
# uncomment types applicable to the change:
  type:
  - documentation   # QoL changes e.g. refactoring

Context

It addresses these post-merge reviews in PR #646:

How to trust this PR

It is a refactoring, no functionality should change. I would just:

  • Read the code and make sure it makes sense and there are no typos.
  • Make sure the new layout is correct.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. See Running tests for more details
  • Self-reviewed the diff

@palas palas added the enhancement New feature or request label Mar 26, 2024
@palas palas self-assigned this Mar 26, 2024
@palas palas mentioned this pull request Mar 26, 2024
Merged
3 tasks
@palas palas added this pull request to the merge queue Mar 27, 2024
Merged via the queue into main with commit a38d570 Mar 27, 2024
17 checks passed
@palas palas deleted the comments-and-indentation branch March 27, 2024 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smelc smelc smelc approved these changes

@Jimbo4350 Jimbo4350 Awaiting requested review from Jimbo4350

@newhoggy newhoggy Awaiting requested review from newhoggy

@carbolymer carbolymer Awaiting requested review from carbolymer

@kevinhammond kevinhammond Awaiting requested review from kevinhammond

@disassembler disassembler Awaiting requested review from disassembler

Assignees

@palas palas

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@palas @smelc