-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix inversion in --include-stake parser + print "stake" field even when there is no stake (do not hide stake absence) #698
Conversation
9d999c1
to
589d436
Compare
<*> pAllOrOnlyDRepHashSoure | ||
<*> Opt.flag WithStake NoStake (mconcat | ||
<*> pAllOrOnlyDRepHashSource | ||
<*> Opt.flag NoStake WithStake (mconcat |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is one of the two important bits of this PR: the arguments to Opt.flag are as follows:
- The default value
- The modified value
Here the two values were inverted. This change fixes that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! One minor comment.
d2ffc8a
to
4d285f0
Compare
Signed-off-by: Clément Hurlin <clement.hurlin@moduscreate.com>
Signed-off-by: Clément Hurlin <clement.hurlin@moduscreate.com>
Signed-off-by: Clément Hurlin <clement.hurlin@moduscreate.com>
4d285f0
to
c382c36
Compare
Changelog
Context
Fixes #623
How to trust this PR
I've tested the behavior of this PR on this branch of
cardano-node
: see the HEAD of https://github.com/IntersectMBO/cardano-node/commits/smelc/test-of-cli-pull-698/Checklist