key non-extended-key: make pattern matches exhaustive, so that we are notified of possible extensions #710
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog
Context
There is a catch-all pattern when matching on https://github.com/IntersectMBO/cardano-api/blob/03de67a58e044c41c62ab8683bffac52771bcd37/cardano-api/internal/Cardano/Api/DeserialiseAnyOf.hs#L237 and it probably bit us in the past, when we extended this type and didn't see that we probably needed to extend the cases being handled.
This PR lists all cases of
SomeAddressVerificationKey
, so that we are notified of changes to make when extending this type.How to trust this PR
It doesn't change the running behavior
Checklist