Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements to governance tests #714

Merged
merged 4 commits into from
Apr 12, 2024
Merged

Conversation

smelc
Copy link
Contributor

@smelc smelc commented Apr 11, 2024

Changelog

- description: |
    Shorten and modernize some governance tests
# uncomment types applicable to the change:
  type:
  # - feature        # introduces a new feature
  # - breaking       # the API has changed in a breaking way
  # - compatible     # the API has changed but is non-breaking
  # - optimisation   # measurable performance improvements
  # - improvement    # QoL changes e.g. refactoring
  # - bugfix         # fixes a defect
  - test           # fixes/modifies tests
  # - maintenance    # not directly related to the code
  # - release        # related to a new release preparation
  # - documentation  # change in code docs, haddocks...

Context

This started out with me working on #706 and on the way I saw multiple ways to improve the existing code. This PR was born.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. See Running tests for more details
  • Self-reviewed the diff

data SomeCommitteeKey f
= ACommitteeHotKey (f CommitteeHotKey)
| ACommitteeColdKey (f CommitteeColdKey)
data SomeCommitteeKey
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that removing the type parameter also aligns with how this kind of type is usually written, see e.g. https://github.com/IntersectMBO/cardano-api/blob/3bbdf8ae962d91602a4d8b0b416e90a0e8024943/cardano-api/internal/Cardano/Api/DeserialiseAnyOf.hs#L237

@smelc smelc added this pull request to the merge queue Apr 12, 2024
Merged via the queue into main with commit d24cb3a Apr 12, 2024
16 checks passed
@smelc smelc deleted the smelc/test-governance-improvements branch April 12, 2024 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants