Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cardano-db-sync): Default --keep-tx-metadata to [] #1613

Merged

Conversation

sgillespie
Copy link
Contributor

@sgillespie sgillespie commented Jan 22, 2024

Description

Should fix:

Jan 22 14:06:16 sean-work nv166z09gcc8fxkmyvv88rzq96h964nq-cardano-db-sync[900363]: Missing: --keep-tx-metadata ARG
Jan 22 14:06:16 sean-work nv166z09gcc8fxkmyvv88rzq96h964nq-cardano-db-sync[900363]: Usage: cardano-db-sync (COMMAND | --config FILEPATH --socket-path FILEPATH
Jan 22 14:06:16 sean-work nv166z09gcc8fxkmyvv88rzq96h964nq-cardano-db-sync[900363]:                          [--state-dir FILEPATH] --schema-dir FILEPATH
Jan 22 14:06:16 sean-work nv166z09gcc8fxkmyvv88rzq96h964nq-cardano-db-sync[900363]:                          [--pg-pass-env ENV] [--disable-epoch] [--disable-cache]
Jan 22 14:06:16 sean-work nv166z09gcc8fxkmyvv88rzq96h964nq-cardano-db-sync[900363]:                          [--disable-ledger] [--dont-use-ledger] [--skip-fix]
Jan 22 14:06:16 sean-work nv166z09gcc8fxkmyvv88rzq96h964nq-cardano-db-sync[900363]:                          [--fix-only] [--force-indexes] [--disable-in-out]
Jan 22 14:06:16 sean-work nv166z09gcc8fxkmyvv88rzq96h964nq-cardano-db-sync[900363]:                          [--disable-shelley] [--disable-multiassets]
Jan 22 14:06:16 sean-work nv166z09gcc8fxkmyvv88rzq96h964nq-cardano-db-sync[900363]:                          [--disable-metadata] --keep-tx-metadata ARG
Jan 22 14:06:16 sean-work nv166z09gcc8fxkmyvv88rzq96h964nq-cardano-db-sync[900363]:                          [--disable-plutus-extra] [--disable-gov]
Jan 22 14:06:16 sean-work nv166z09gcc8fxkmyvv88rzq96h964nq-cardano-db-sync[900363]:                          [--disable-offchain-pool-data] [--force-tx-in]
Jan 22 14:06:16 sean-work nv166z09gcc8fxkmyvv88rzq96h964nq-cardano-db-sync[900363]:                          [--disable-all] [--full] [--only-utxo] [--only-gov]
Jan 22 14:06:16 sean-work nv166z09gcc8fxkmyvv88rzq96h964nq-cardano-db-sync[900363]:                          [--consumed-tx-out] [--prune-tx-out]
Jan 22 14:06:16 sean-work nv166z09gcc8fxkmyvv88rzq96h964nq-cardano-db-sync[900363]:                          [--bootstrap-tx-out] [--rollback-to-slot WORD])
Jan 22 14:06:16 sean-work nv166z09gcc8fxkmyvv88rzq96h964nq-cardano-db-sync[900363]:   Cardano PostgreSQL sync node.
Jan 22 14:06:16 sean-work systemd[1]: cardano-db-sync.service: Main process exited, code=exited, status=1/FAILURE

Checklist

  • Commit sequence broadly makes sense
  • Commits have useful messages
  • New tests are added if needed and existing tests are updated
  • Any changes are noted in the changelog
  • Code is formatted with fourmolu on version 0.10.1.0 (which can be run with scripts/fourmolize.sh)
  • Self-reviewed the diff

Migrations

  • The pr causes a breaking change of type a,b or c
  • If there is a breaking change, the pr includes a database migration and/or a fix process for old values, so that upgrade is possible
  • Resyncing and running the migrations provided will result in the same database semantically

If there is a breaking change, especially a big one, please add a justification here. Please elaborate
more what the migration achieves, what it cannot achieve or why a migration is not possible.

@sgillespie sgillespie marked this pull request as ready for review January 22, 2024 20:13
Copy link
Contributor

@Cmdv Cmdv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank @sgillespie hadn't spoted that was under the impression that due to the many it would auto return a [] and hadn't seen the error message 🤦

@sgillespie sgillespie merged commit 061745e into IntersectMBO:master Jan 22, 2024
7 of 10 checks passed
@sgillespie sgillespie deleted the fix/optional-keep-tx-metadata branch January 22, 2024 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants