Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Shelley Insert.hs #1635

Merged
merged 3 commits into from
Mar 5, 2024
Merged

Refactor Shelley Insert.hs #1635

merged 3 commits into from
Mar 5, 2024

Conversation

Cmdv
Copy link
Contributor

@Cmdv Cmdv commented Feb 29, 2024

Description

Refactoring /Cardano/DbSync/Era/Shelley/Insert.hs into smaller modules.

Checklist

  • Commit sequence broadly makes sense
  • Commits have useful messages
  • New tests are added if needed and existing tests are updated
  • Any changes are noted in the changelog
  • Code is formatted with fourmolu on version 0.10.1.0 (which can be run with scripts/fourmolize.sh)
  • Self-reviewed the diff

Migrations

  • The pr causes a breaking change of type a,b or c
  • If there is a breaking change, the pr includes a database migration and/or a fix process for old values, so that upgrade is possible
  • Resyncing and running the migrations provided will result in the same database semantically

If there is a breaking change, especially a big one, please add a justification here. Please elaborate
more what the migration achieves, what it cannot achieve or why a migration is not possible.

@Cmdv Cmdv requested review from sgillespie and kderme February 29, 2024 11:07
@Cmdv Cmdv force-pushed the cmdv-refactor-shelley-insert branch from f605918 to c30e78f Compare February 29, 2024 11:09
@sgillespie
Copy link
Contributor

sgillespie commented Mar 1, 2024

This is a massive improvement. However, I wonder if we need the Insert/*.hs nesting. Everything in Era/Shelley is inserting so I think we could probably flatten that out a bit.

EDIT: After further review, there's lots of stuff that does not do inserting that I didn't see last week. I'm back to liking the Insert/X.hs nesting

sgillespie
sgillespie previously approved these changes Mar 1, 2024
@Cmdv Cmdv force-pushed the cmdv-refactor-shelley-insert branch from c30e78f to 15ffb63 Compare March 4, 2024 12:36
@Cmdv Cmdv force-pushed the cmdv-refactor-shelley-insert branch from 15ffb63 to 66f8a0a Compare March 4, 2024 13:21
@Cmdv Cmdv force-pushed the cmdv-refactor-shelley-insert branch from cd4a024 to 68dbf7b Compare March 5, 2024 14:03
Copy link
Contributor

@sgillespie sgillespie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Cmdv Cmdv merged commit 77cd794 into master Mar 5, 2024
14 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants