vote offchain data support #1654
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kderme
force-pushed
the
kderme/offchain
branch
2 times, most recently
from
55e934b to
df61aca
Compare
Cmdv
requested changes
Mar 18, 2024
cardano-db-sync/src/Cardano/DbSync/Era/Universal/Insert/GovAction.hs
Outdated
Show resolved
Hide resolved
kderme
force-pushed
the
kderme/offchain
branch
2 times, most recently
from
28d0bb3 to
af46a88
Compare
The types match CIP-100 and CIP-108
|
@Cmdv addressed and fixed a bug with |
sgillespie
reviewed
Mar 18, 2024
| OffChainVoteDataOther dt -> language $ context dt | ||
| OffChainVoteDataGa dt -> language $ context dt | ||
|
|
||
| data OffChainVoteDataTp tp = OffChainVoteDataTp |
There was a problem hiding this comment.
What's TP? Can you add a comment that tells us?
sgillespie
reviewed
Mar 18, 2024
| } | ||
| deriving (Show, Generic, FromJSON) | ||
|
|
||
| data GABody = GABody |
There was a problem hiding this comment.
I presume this is also Governance Action Body?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Partial implementation of CIp-100 and CIP-108
Checklist
fourmoluon version 0.10.1.0 (which can be run withscripts/fourmolize.sh)Migrations
b type migration to add offchain vote data support