Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build: Add SMASH docker image #1668

Merged
merged 4 commits into from
Apr 8, 2024

Conversation

sgillespie
Copy link
Contributor

@sgillespie sgillespie commented Apr 3, 2024

Description

Partially fixes #1649. Adds a new image cardano-smash-server and a ghcr.io image registry. It should follow all of the conventions established in the cardano-db-sync image, which means it will accept variables for:

  • NETWORK
  • POSTGRES_USER
  • POSTGRES_PASSWORD
  • POSTGRES_HOST
  • POSTGRES_PORT

Furthermore, we add the following variables:

  • SMASH_USER
  • SMASH_PASSWORD

To generate the credentials for basic authentication.

After this is merged, I will backport this to previous released 13.2.x and 13.1.x.

Checklist

  • Commit sequence broadly makes sense
  • Commits have useful messages
  • New tests are added if needed and existing tests are updated
  • Any changes are noted in the changelog
  • Code is formatted with fourmolu on version 0.10.1.0 (which can be run with scripts/fourmolize.sh)
  • Self-reviewed the diff

Migrations

  • The pr causes a breaking change of type a,b or c
  • If there is a breaking change, the pr includes a database migration and/or a fix process for old values, so that upgrade is possible
  • Resyncing and running the migrations provided will result in the same database semantically

If there is a breaking change, especially a big one, please add a justification here. Please elaborate
more what the migration achieves, what it cannot achieve or why a migration is not possible.

@sgillespie sgillespie force-pushed the feature/docker-smash branch from 54337ec to 013a56c Compare April 4, 2024 20:31
@sgillespie sgillespie marked this pull request as ready for review April 5, 2024 13:48
Copy link
Contributor

@michalrus michalrus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! 🙇 Do you plan to backport it to 13.1.0.0?

@sgillespie sgillespie merged commit 2158eb8 into IntersectMBO:master Apr 8, 2024
9 of 11 checks passed
@sgillespie sgillespie deleted the feature/docker-smash branch April 8, 2024 17:19
@sgillespie
Copy link
Contributor Author

sgillespie commented Apr 8, 2024

Thank you! 🙇 Do you plan to backport it to 13.1.0.0?

I have backported to 13.1.0.2: https://github.com/IntersectMBO/cardano-db-sync/pkgs/container/cardano-smash-server/201109389?tag=13.1.0.2

@ginnun
Copy link

ginnun commented Apr 17, 2024

@sgillespie The link above points to 13.2.0.1, but we are interested in 13.1.0.2. I lost some time blindly following the link ^^
Anyways, the image for 13.1.0.2 exists and works with our db-sync default of 13.1.0.0.
And it was almost effortless to use it. Thank you.

@sgillespie
Copy link
Contributor Author

Sorry about that! I've updated my comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add OCI image for smash server
5 participants