Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Cleanup macOS pre-installed libraries #1670

Merged
merged 1 commit into from
Apr 5, 2024

Conversation

sgillespie
Copy link
Contributor

@sgillespie sgillespie commented Apr 4, 2024

Description

Fixes #1663. The Github Actions runner for macOS ships with icu4c that conflicts with Nix's. In particular the text-icu Hackage package explicitly adds Homebrew's lib-dirs. With this change, we uninstall the package from Homebrew, forcing the version from nix to be used.

Checklist

  • Commit sequence broadly makes sense
  • Commits have useful messages
  • New tests are added if needed and existing tests are updated
  • Any changes are noted in the changelog
  • Code is formatted with fourmolu on version 0.10.1.0 (which can be run with scripts/fourmolize.sh)
  • Self-reviewed the diff

Migrations

  • The pr causes a breaking change of type a,b or c
  • If there is a breaking change, the pr includes a database migration and/or a fix process for old values, so that upgrade is possible
  • Resyncing and running the migrations provided will result in the same database semantically

If there is a breaking change, especially a big one, please add a justification here. Please elaborate
more what the migration achieves, what it cannot achieve or why a migration is not possible.

@sgillespie sgillespie merged commit d88332b into IntersectMBO:master Apr 5, 2024
9 of 11 checks passed
@sgillespie sgillespie deleted the fix/gha-macos branch April 5, 2024 01:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't build master with cabal
2 participants