db: Fix for the outsum column of the epoch table #201
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This column is the sum of transactions outputs for the epoch. On
test networks (never been seen on mainnet) it is possible for this
sum to end up larger than the maximum positive value that can be
stored in a 64 bit signed integer ('Int64'). However, the output sum
was being stored store in a 64 bit unsigned integer ('Word64') but
the Persistent library does not correctly supported 'Word64'. Instead
it "casts" it from 'Word64' to 'Int64'. For values great that the
max positive value of an 'Int64' this results on the value wrapping
to negative and hence being rejected by the SQL domain constraint
which requres 'outsum >= 0'.
This solution switches 'outsum' in the Haskell world from 'Word64'
to 'Word128' which is incredibly unlikley to overflow given the
limitation on number of transactions per block and per epoch. On
the SQL side we use an PostgreSQL type of 'numeric (38, 0)'.
Closes: #197
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.