Avoid address serialisation roundtrip #682
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kderme
force-pushed
the
kderme/address-round-trip
branch
from
735476d to
34b0714
Compare
|
I've synced with and without the pr and found no differences on the tx_out table. |
|
Pulled into #864 . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The TxOut patterns for addresses that we use, do a silent deserialisation. Later we serialise addresses again to insert them in the db. We can avoid this round trip by keeping the initial serialised address
This can be optimised even further.
Generic.renderAddressdoes another serialization before transforming to the bech32/base58 format. We could use the serialised address to avoid this. However the cardano-api doesn't make this too easy.