Fix foreign key #807
Fix foreign key #807
Conversation
| encodeData :: Alonzo.Data StandardAlonzo -> ByteString | ||
| encodeData dt = LBS.toStrict $ Aeson.encode $ | ||
| Api.scriptDataToJson Api.ScriptDataJsonDetailedSchema $ Api.fromAlonzoData dt | ||
| Api.scriptDataToJson Api.ScriptDataJsonNoSchema $ Api.fromAlonzoData dt |
There was a problem hiding this comment.
What's the reason for this one? Wouldn't we loose some expressiveness regarding constructors?
There was a problem hiding this comment.
DetailedSchema doesn't seem very user friendly
There was a problem hiding this comment.
I think this should keep using DetailedSchema to have the full representational capacity as outlined in https://github.com/input-output-hk/cardano-node/blob/master/cardano-api/src/Cardano/Api/ScriptData.hs#L238-L299
Quoting the most relevant part
It also means any script data can be converted into the JSON and
back without loss. That is we can round-trip the script data via the JSON and
also round-trip schema-compliant JSON via script data.
which according to my understanding means that NoSchema is lossy as in some cases you can't convert NoSchema JSON to original ScriptData.
If an explorer or some tool wants to display user-friendly NoSchema it can convert DetailedSchema to ScriptData and then build NoSchema one.
|
Have taken the "Fix foreign key" commit in #864. Closing this. |
3 participants
No description provided.