Bump CHaP, fix issues #3092
Merged
Bump CHaP, fix issues #3092
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The main issue was with the old version of `cardano-prelude` being forced by `cardano-ledger-byron`. But in fact the other packages had already migrated for the `heapwords` change, so I just did that for `cardano-ledger-byron` also and dropped the constraint.
JaredCorduan
approved these changes
Oct 18, 2022
There was a problem hiding this comment.
thank you @michaelpj , this makes sense of our recently build failures
|
Apologies yet again for the chaos 🙇 |
|
not at all @michaelpj , thank you for all your hard work making this a reality!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main issue was with the old version of
cardano-preludebeing forced bycardano-ledger-byron. But in fact the other packages had already migrated for theheapwordschange, so I just did that forcardano-ledger-byronalso and dropped the constraint.IMPORTANT: due to us having to mess with CHaP recently, you may find things behave a bit oddly until we get this merged, so please take a look ASAP.