Utxow Predicate failure tests #4213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teodanciu
force-pushed
the
td/utxow-predfailures-tests
branch
3 times, most recently
from
214b4af
to
7d4e35b
Compare
teodanciu
force-pushed
the
td/utxow-predfailures-tests
branch
9 times, most recently
from
97d0664
to
20ff045
Compare
teodanciu
force-pushed
the
td/utxow-predfailures-tests
branch
2 times, most recently
from
edcdac2
to
f7487be
Compare
teodanciu
force-pushed
the
td/utxow-predfailures-tests
branch
2 times, most recently
from
91ec8ae
to
9b06a3e
Compare
lehins
requested changes
Apr 16, 2024
eras/alonzo/impl/testlib/Test/Cardano/Ledger/Alonzo/Imp/UtxowSpec.hs
Outdated
Show resolved
Hide resolved
eras/alonzo/impl/testlib/Test/Cardano/Ledger/Alonzo/Imp/UtxowSpec.hs
Outdated
Show resolved
Hide resolved
eras/alonzo/impl/testlib/Test/Cardano/Ledger/Alonzo/Imp/UtxowSpec.hs
Outdated
Show resolved
Hide resolved
eras/alonzo/impl/testlib/Test/Cardano/Ledger/Alonzo/Imp/UtxowSpec.hs
Outdated
Show resolved
Hide resolved
eras/shelley/impl/testlib/Test/Cardano/Ledger/Shelley/Imp/UtxowSpec.hs
Outdated
Show resolved
Hide resolved
eras/allegra/impl/testlib/Test/Cardano/Ledger/Allegra/Imp/UtxowSpec.hs
Outdated
Show resolved
Hide resolved
eras/allegra/impl/testlib/Test/Cardano/Ledger/Allegra/Imp/UtxowSpec.hs
Outdated
Show resolved
Hide resolved
eras/allegra/impl/testlib/Test/Cardano/Ledger/Allegra/Imp/UtxowSpec.hs
Outdated
Show resolved
Hide resolved
eras/shelley/impl/testlib/Test/Cardano/Ledger/Shelley/ImpTest.hs
Outdated
Show resolved
Hide resolved
teodanciu
force-pushed
the
td/utxow-predfailures-tests
branch
from
9b06a3e
to
f0b3f9a
Compare
|
I have rewritten most of these tests to make more use of postFixup. In the initial version, I was trying to produce the exact list of failures, and for that, the fixing up was more complicated and less comprehensible. If you wanted to have another look @lehins when you have time. Also, @neilmayhew - hope this isn't too much interfering with the work on your other (related) PR. |
teodanciu
force-pushed
the
td/utxow-predfailures-tests
branch
from
f0b3f9a
to
68c10ef
Compare
neilmayhew
reviewed
May 21, 2024
teodanciu
force-pushed
the
td/utxow-predfailures-tests
branch
from
68c10ef
to
7b6b3dd
Compare
lehins
requested changes
May 22, 2024
There was a problem hiding this comment.
Ok, I do have a problem with submitFailingTxWithSubset. There is a proposed solution on how to solve this in the review.
Also the PredicteFailrues that do not roundtrip as expected can be tested for that as well.
Other than that this PR is looking much better than before 😉 thanks to all of the work you've done in other PRs.
eras/shelley/impl/testlib/Test/Cardano/Ledger/Shelley/ImpTest.hs
Outdated
Show resolved
Hide resolved
eras/shelley/impl/testlib/Test/Cardano/Ledger/Shelley/Imp/UtxowSpec.hs
Outdated
Show resolved
Hide resolved
eras/shelley/impl/testlib/Test/Cardano/Ledger/Shelley/ImpTest.hs
Outdated
Show resolved
Hide resolved
teodanciu
force-pushed
the
td/utxow-predfailures-tests
branch
6 times, most recently
from
b550f3d
to
0bf021b
Compare
teodanciu
force-pushed
the
td/utxow-predfailures-tests
branch
from
0bf021b
to
e4311d0
Compare
lehins
approved these changes
May 23, 2024
eras/shelley/impl/testlib/Test/Cardano/Ledger/Shelley/ImpTest.hs
Outdated
Show resolved
Hide resolved
eras/shelley/impl/testlib/Test/Cardano/Ledger/Shelley/ImpTest.hs
Outdated
Show resolved
Hide resolved
in order to support testing failures for which we know that the roundtripping is not working (and needs to be kept like this for backwards compatibility)
to enable testing invalid scripts
teodanciu
force-pushed
the
td/utxow-predfailures-tests
branch
from
e4311d0
to
e0ff234
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Tests for UTXOW Predicate failures, part of #4185
InvalidWitnessesUTXOW
MissingVKeyWitnessesUTXOW
MissingScriptWitnessesUTXOW
ScriptWitnessNotValidatingUTXOW
MissingTxBodyMetadataHash
MissingTxMetadata
ConflictingMetadataHash
InvalidMetadata
ExtraneousScriptWitnessesUTXOW
MissingRedeemers
MissingRequiredDatums
NotAllowedSupplementalDatums
PPViewHashesDontMatch
UnspendableUTxONoDatumHash
ExtraRedeemers
MalformedScriptWitnesses
MalformedReferenceScripts
Checklist
.cabalandCHANGELOG.mdfiles according to theversioning process.
.cabalfiles for all affected packages are updated. If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)CHANGELOG.mdfor the affected packages. New section is never added with the code changes. (See RELEASING.md)fourmolu(usescripts/fourmolize.sh)scripts/cabal-format.sh)hie.yamlhas been updated (usescripts/gen-hie.sh)