Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

constrained-generators: Add explanation :: [String] -> Pred fn -> Pred fn #4345

Merged
merged 6 commits into from
May 28, 2024

Conversation

MaximilianAlgehed
Copy link
Collaborator

Description

By request from @TimSheard

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated
  • When applicable, versions are updated in .cabal and CHANGELOG.md files according to the
    versioning process.
  • The version bounds in .cabal files for all affected packages are updated. If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)
  • All visible changes are prepended to the latest section of a CHANGELOG.md for the affected packages. New section is never added with the code changes. (See RELEASING.md)
  • Code is formatted with fourmolu (use scripts/fourmolize.sh)
  • Cabal files are formatted (use scripts/cabal-format.sh)
  • hie.yaml has been updated (use scripts/gen-hie.sh)
  • Self-reviewed the diff

Copy link
Contributor

@TimSheard TimSheard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Anything that makes better explanations is Good!

libs/constrained-generators/src/Constrained/Base.hs Outdated Show resolved Hide resolved
@MaximilianAlgehed MaximilianAlgehed force-pushed the PR-explanation branch 2 times, most recently from e52c867 to 656c4e5 Compare May 24, 2024 13:51
@MaximilianAlgehed MaximilianAlgehed force-pushed the PR-explanation branch 10 times, most recently from 7311ecb to bc38adc Compare May 28, 2024 12:52
@MaximilianAlgehed MaximilianAlgehed merged commit 739af9e into master May 28, 2024
14 of 20 checks passed
@MaximilianAlgehed MaximilianAlgehed deleted the PR-explanation branch May 28, 2024 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants