Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DRep state query and related tests #4364

Merged
merged 1 commit into from
Jun 3, 2024
Merged

Conversation

aniketd
Copy link
Contributor

@aniketd aniketd commented May 27, 2024

Description

Depends on #4358

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated
  • When applicable, versions are updated in .cabal and CHANGELOG.md files according to the
    versioning process.
  • The version bounds in .cabal files for all affected packages are updated. If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)
  • All visible changes are prepended to the latest section of a CHANGELOG.md for the affected packages. New section is never added with the code changes. (See RELEASING.md)
  • Code is formatted with fourmolu (use scripts/fourmolize.sh)
  • Cabal files are formatted (use scripts/cabal-format.sh)
  • hie.yaml has been updated (use scripts/gen-hie.sh)
  • Self-reviewed the diff

@aniketd aniketd force-pushed the aniketd/drep-dormant-epochs-query branch from 854c915 to 996e630 Compare May 28, 2024 10:24
@aniketd aniketd marked this pull request as ready for review May 28, 2024 11:35
@aniketd aniketd force-pushed the aniketd/drep-dormant-epochs-query branch from 996e630 to c2e28a0 Compare May 29, 2024 15:11
@aniketd aniketd requested a review from Soupstraw May 29, 2024 15:39
@aniketd aniketd force-pushed the aniketd/drep-dormant-epochs-query branch 3 times, most recently from 4f43c10 to ff8b99f Compare May 31, 2024 09:56
@lehins lehins enabled auto-merge (squash) June 1, 2024 16:35
Copy link
Collaborator

@lehins lehins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Thank you.

@lehins lehins force-pushed the aniketd/drep-dormant-epochs-query branch from 836707b to 3f0f21f Compare June 2, 2024 19:08
Reuse functionality introduced in #4358 to do the correct update of
DRep expiry. Also ensure this correct expiry update happens regardless
whether credential filtering is applied or not.
@lehins lehins force-pushed the aniketd/drep-dormant-epochs-query branch from 3f0f21f to 15e6809 Compare June 2, 2024 19:15
@lehins lehins merged commit fdd6a9a into master Jun 3, 2024
123 of 127 checks passed
@lehins lehins deleted the aniketd/drep-dormant-epochs-query branch June 3, 2024 05:05
tdammers pushed a commit that referenced this pull request Jul 23, 2024
* DRepState query now returns the correct expiry, regardless of the filtering: fixes #4349
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants