Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed 8.10 not building #4367

Merged
merged 1 commit into from
May 29, 2024
Merged

Fixed 8.10 not building #4367

merged 1 commit into from
May 29, 2024

Conversation

Soupstraw
Copy link
Contributor

@Soupstraw Soupstraw commented May 28, 2024

Description

There seems to be a problem with some Inject constraints in ExecSpecRule. It looks like 8.10 can derive some identity constraints from the Inject a a instance, but GHC 9 complains about overlapping instances.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated
  • When applicable, versions are updated in .cabal and CHANGELOG.md files according to the
    versioning process.
  • The version bounds in .cabal files for all affected packages are updated. If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)
  • All visible changes are prepended to the latest section of a CHANGELOG.md for the affected packages. New section is never added with the code changes. (See RELEASING.md)
  • Code is formatted with fourmolu (use scripts/fourmolize.sh)
  • Cabal files are formatted (use scripts/cabal-format.sh)
  • hie.yaml has been updated (use scripts/gen-hie.sh)
  • Self-reviewed the diff

@Soupstraw Soupstraw force-pushed the jj/redundant-constraints-fix branch 4 times, most recently from da5b3f1 to 54ba901 Compare May 28, 2024 15:10
@Soupstraw Soupstraw enabled auto-merge (rebase) May 28, 2024 15:12
Copy link
Contributor

@teodanciu teodanciu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, let's maybe check that it passes for all the builds before merging, since at the moment this check is not correct in CI.

@Soupstraw Soupstraw disabled auto-merge May 28, 2024 15:21
@lehins lehins force-pushed the jj/redundant-constraints-fix branch from 54ba901 to 4179a75 Compare May 29, 2024 00:35
@lehins lehins enabled auto-merge May 29, 2024 00:35
@lehins lehins merged commit b3b8b3d into master May 29, 2024
118 of 126 checks passed
@lehins lehins deleted the jj/redundant-constraints-fix branch May 29, 2024 02:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants