Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conformance test plumbing: EPOCH #4425

Merged
merged 2 commits into from
Jun 24, 2024
Merged

Conformance test plumbing: EPOCH #4425

merged 2 commits into from
Jun 24, 2024

Conversation

aniketd
Copy link
Contributor

@aniketd aniketd commented Jun 19, 2024

Description

Partly addresses #4381 and #4427

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated
  • When applicable, versions are updated in .cabal and CHANGELOG.md files according to the
    versioning process.
  • The version bounds in .cabal files for all affected packages are updated. If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)
  • All visible changes are prepended to the latest section of a CHANGELOG.md for the affected packages. New section is never added with the code changes. (See RELEASING.md)
  • Code is formatted with fourmolu (use scripts/fourmolize.sh)
  • Cabal files are formatted (use scripts/cabal-format.sh)
  • hie.yaml has been updated (use scripts/gen-hie.sh)
  • Self-reviewed the diff

@aniketd aniketd changed the title Conformance: EPOCH Conformance test plumbing: EPOCH Jun 19, 2024
@aniketd aniketd marked this pull request as ready for review June 19, 2024 16:28
@aniketd aniketd mentioned this pull request Jun 19, 2024
80 tasks
Copy link
Contributor

@Lucsanszky Lucsanszky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Collaborator

@lehins lehins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Make the test type-check and execute, but without
any adjustment to the generators.
@aniketd aniketd merged commit fd5024f into master Jun 24, 2024
125 checks passed
@aniketd aniketd deleted the aniketd/conformance-epoch branch June 24, 2024 17:43
@aniketd aniketd mentioned this pull request Jun 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants