Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Authorize known cc members only #4436

Merged
merged 6 commits into from
Jun 27, 2024
Merged

Conversation

lehins
Copy link
Collaborator

@lehins lehins commented Jun 25, 2024

Description

In order to prevent garbage hot key authorizations we fail on certificates that mention cold credentials that do not exist somewhere in the ledger state, be it in current constitutional committee or in one of active proposals.

Thanks to @Hornan7 for reporting this issue.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated
  • When applicable, versions are updated in .cabal and CHANGELOG.md files according to the
    versioning process.
  • The version bounds in .cabal files for all affected packages are updated. If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)
  • All visible changes are prepended to the latest section of a CHANGELOG.md for the affected packages. New section is never added with the code changes. (See RELEASING.md)
  • Code is formatted with fourmolu (use scripts/fourmolize.sh)
  • Cabal files are formatted (use scripts/cabal-format.sh)
  • hie.yaml has been updated (use scripts/gen-hie.sh)
  • Self-reviewed the diff

@lehins lehins force-pushed the lehins/authorize-known-cc-members-only branch from f9c8373 to 5c90b11 Compare June 25, 2024 19:03
Copy link
Contributor

@aniketd aniketd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Copy link
Contributor

@teodanciu teodanciu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changelog for conway is missing:

* Added `ConwayCommitteeIsUnknown` predicate failure to  `ConwayGovCertPredFailure`  
* Added `cgceCurrentCommittee` and `cgceCommitteeProposals` to `ConwayGovCertEnv`

@lehins lehins force-pushed the lehins/authorize-known-cc-members-only branch from 3fd179f to 0bca506 Compare June 27, 2024 00:16
@lehins lehins force-pushed the lehins/authorize-known-cc-members-only branch from 0bca506 to 02a16b2 Compare June 27, 2024 02:30
@lehins lehins enabled auto-merge June 27, 2024 02:46
@lehins lehins merged commit 0ed1bfc into master Jun 27, 2024
125 checks passed
@lehins lehins deleted the lehins/authorize-known-cc-members-only branch June 27, 2024 04:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants