Use lenses for JSON editing. Upgrade to hedgehog-extras0.5.1.0
#5626
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
newhoggy
force-pushed
the
newhoggy/upgrade-to-cardano-cli-8.17.0.0-and-cardano-api-8.37.0.0
branch
from
c767c8d
to
04fc77d
Compare
newhoggy
commented
Jan 6, 2024
| & L.key "rho" . L._Double .~ 0.1 | ||
| & L.key "tau" . L._Double .~ 0.1 | ||
| & L.key "updateQuorum" . L._Integer .~ 2 | ||
| & L.key "protocolParams" . L.key "protocolVersion" . L.key "major" . L._Integer .~ 8 |
There was a problem hiding this comment.
It turns out that lenses make a good compatibility shim. The aeson API keeps making breaking changes (for example switching from HashMap to KeyMap lenses help us having to deal with these breaking changes.
newhoggy
force-pushed
the
newhoggy/upgrade-to-cardano-cli-8.17.0.0-and-cardano-api-8.37.0.0
branch
from
04fc77d
to
176cddf
Compare
|
Kind of superceded by #5621 ? |
carbolymer
reviewed
Jan 11, 2024
Comment on lines
+110
to
+111
| & L.key "rho" . L._Double .~ 0.1 | ||
| & L.key "tau" . L._Double .~ 0.1 |
There was a problem hiding this comment.
Those are wrong, rho and tau can't be at the top level.
I am going to steal your lenses idea and put it into my PR. 😄
There was a problem hiding this comment.
Where should they go instead?
There was a problem hiding this comment.
This is not a regression in any case.
There was a problem hiding this comment.
Inside protocolParams. This change just went overlooked, and I've stumbled upon it.
newhoggy
force-pushed
the
newhoggy/upgrade-to-cardano-cli-8.17.0.0-and-cardano-api-8.37.0.0
branch
3 times, most recently
from
85e6323
to
0db4af8
Compare
newhoggy
changed the title
cardano-cli-8.17.0.0 and cardano-api-8.37.0.0hedgehog-extras0.5.1.0
smelc
approved these changes
Jan 12, 2024
carbolymer
approved these changes
Jan 12, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
newhoggy
force-pushed
the
newhoggy/upgrade-to-cardano-cli-8.17.0.0-and-cardano-api-8.37.0.0
branch
from
0db4af8
to
28b8f0f
Compare
newhoggy
deleted the
newhoggy/upgrade-to-cardano-cli-8.17.0.0-and-cardano-api-8.37.0.0
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Upgrade to
hedgehog-extras-0.5.1.0. Use lenses for JSON editing.Checklist
See Runnings tests for more details
CHANGELOG.mdfor affected package.cabalfiles are updatedhlint. See.github/workflows/check-hlint.ymlto get thehlintversionstylish-haskell. See.github/workflows/stylish-haskell.ymlto get thestylish-haskellversionghc-8.10.7andghc-9.2.7Note on CI
If your PR is from a fork, the necessary CI jobs won't trigger automatically for security reasons.
You will need to get someone with write privileges. Please contact IOG node developers to do this
for you.