Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable ledger events governance test temporarily #5640

Merged
merged 1 commit into from
Jan 19, 2024

Conversation

Jimbo4350
Copy link
Contributor

Description

Add your description here, if it fixes a particular issue please provide a
link
to the issue.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. These may include:
    • golden tests
    • property tests
    • roundtrip tests
    • integration tests
      See Runnings tests for more details
  • Any changes are noted in the CHANGELOG.md for affected package
  • The version bounds in .cabal files are updated
  • CI passes. See note on CI. The following CI checks are required:
    • Code is linted with hlint. See .github/workflows/check-hlint.yml to get the hlint version
    • Code is formatted with stylish-haskell. See .github/workflows/stylish-haskell.yml to get the stylish-haskell version
    • Code builds on Linux, MacOS and Windows for ghc-8.10.7 and ghc-9.2.7
  • Self-reviewed the diff

Note on CI

If your PR is from a fork, the necessary CI jobs won't trigger automatically for security reasons.
You will need to get someone with write privileges. Please contact IOG node developers to do this
for you.

@Jimbo4350 Jimbo4350 force-pushed the jordan/disable-ledger-events-on-mac branch from 652a5e2 to 8d675be Compare January 16, 2024 12:40
@Jimbo4350 Jimbo4350 changed the title Disable ledger events governance test on mac Disable ledger events governance test temporarily Jan 16, 2024
@Jimbo4350 Jimbo4350 force-pushed the jordan/disable-ledger-events-on-mac branch from 8d675be to 4307251 Compare January 19, 2024 18:07
@Jimbo4350 Jimbo4350 added this pull request to the merge queue Jan 19, 2024
Merged via the queue into master with commit da5a64e Jan 19, 2024
20 checks passed
@Jimbo4350 Jimbo4350 deleted the jordan/disable-ledger-events-on-mac branch January 19, 2024 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants