Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump hedgehog-extras 0.6.0.1 #5647

Merged
merged 1 commit into from
Jan 25, 2024
Merged

Conversation

carbolymer
Copy link
Contributor

Description

This PR upgrades hedgehog-extras to 0.6.0.1 to include fix related to printing stderr in failed tests.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. These may include:
    • golden tests
    • property tests
    • roundtrip tests
    • integration tests
      See Runnings tests for more details
  • Any changes are noted in the CHANGELOG.md for affected package
  • The version bounds in .cabal files are updated
  • CI passes. See note on CI. The following CI checks are required:
    • Code is linted with hlint. See .github/workflows/check-hlint.yml to get the hlint version
    • Code is formatted with stylish-haskell. See .github/workflows/stylish-haskell.yml to get the stylish-haskell version
    • Code builds on Linux, MacOS and Windows for ghc-8.10.7 and ghc-9.2.7
  • Self-reviewed the diff

Note on CI

If your PR is from a fork, the necessary CI jobs won't trigger automatically for security reasons.
You will need to get someone with write privileges. Please contact IOG node developers to do this
for you.

@@ -13,8 +13,8 @@ repository cardano-haskell-packages
-- See CONTRIBUTING for information about these, including some Nix commands
-- you need to run if you change them
index-state:
, hackage.haskell.org 2024-01-16T14:48:13Z
, cardano-haskell-packages 2024-01-18T16:26:04Z
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Out of curiosity, why did you bump CHaP? It's not strictly necessary in this PR right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No it's not. In general it's good to have similar versions of hackage and chap (chap > hackage ideally), because chap packages were built against quite recent hackage, so it just gives us bigger probability of chap packages compatibility.

@carbolymer carbolymer enabled auto-merge January 24, 2024 16:21
@carbolymer carbolymer disabled auto-merge January 25, 2024 09:15
@carbolymer carbolymer merged commit 03fb7f7 into master Jan 25, 2024
20 of 27 checks passed
@carbolymer carbolymer deleted the mgalazyn/fix/new-hedgehog-extras branch January 25, 2024 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants