Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use environment variable for network magic instead of CLI arg in testnet tests #5658

Merged
merged 1 commit into from
Feb 1, 2024

Conversation

carbolymer
Copy link
Contributor

Description

This PR adds network magic environment variable to ExecConfig used to invoke cardano-cli in testnet. This reduces boilerplate required to call online commands of cardano-cli.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. These may include:
    • golden tests
    • property tests
    • roundtrip tests
    • integration tests
      See Runnings tests for more details
  • Any changes are noted in the CHANGELOG.md for affected package
  • The version bounds in .cabal files are updated
  • CI passes. See note on CI. The following CI checks are required:
    • Code is linted with hlint. See .github/workflows/check-hlint.yml to get the hlint version
    • Code is formatted with stylish-haskell. See .github/workflows/stylish-haskell.yml to get the stylish-haskell version
    • Code builds on Linux, MacOS and Windows for ghc-8.10.7 and ghc-9.2.7
  • Self-reviewed the diff

Note on CI

If your PR is from a fork, the necessary CI jobs won't trigger automatically for security reasons.
You will need to get someone with write privileges. Please contact IOG node developers to do this
for you.

@smelc
Copy link
Contributor

smelc commented Feb 1, 2024

Amen to less boilerplate

@carbolymer carbolymer added this pull request to the merge queue Feb 1, 2024
Copy link
Contributor

@Jimbo4350 Jimbo4350 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@carbolymer carbolymer removed this pull request from the merge queue due to a manual request Feb 1, 2024
@carbolymer carbolymer merged commit 87aa5e6 into master Feb 1, 2024
19 of 20 checks passed
@carbolymer carbolymer deleted the mgalazyn/add/use-env-var-for-testnet-magic branch February 1, 2024 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants