Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PARALLEL_TESTNETS flag #5706

Merged
merged 1 commit into from
Mar 5, 2024

Conversation

carbolymer
Copy link
Contributor

@carbolymer carbolymer commented Mar 5, 2024

Description

This PR adds PARALLEL_TESTNETS environment flag which controls concurrent execution of testnets. By default concurrent execution is disabled.

This is also a workaround for broken TASTY_PATTERN which does not seem to work with sequentialTestGroup. To run a single test with a matching pattern, execute:

PARALLEL_TESTNETS=1 TASTY_PATTERN='/leadership-schedule/' cabal test cardano-testnet-test

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. These may include:
    • golden tests
    • property tests
    • roundtrip tests
    • integration tests
      See Runnings tests for more details
  • Any changes are noted in the CHANGELOG.md for affected package
  • The version bounds in .cabal files are updated
  • CI passes. See note on CI. The following CI checks are required:
    • Code is linted with hlint. See .github/workflows/check-hlint.yml to get the hlint version
    • Code is formatted with stylish-haskell. See .github/workflows/stylish-haskell.yml to get the stylish-haskell version
    • Code builds on Linux, MacOS and Windows for ghc-8.10.7 and ghc-9.2.7
  • Self-reviewed the diff

Note on CI

If your PR is from a fork, the necessary CI jobs won't trigger automatically for security reasons.
You will need to get someone with write privileges. Please contact IOG node developers to do this
for you.

@carbolymer carbolymer marked this pull request as ready for review March 5, 2024 14:51
@carbolymer carbolymer requested a review from a team as a code owner March 5, 2024 14:51
@carbolymer carbolymer force-pushed the mgalazyn/test/expose-parallel-testnet-flag branch from aec35a3 to 54011f0 Compare March 5, 2024 15:19
@carbolymer carbolymer force-pushed the mgalazyn/test/expose-parallel-testnet-flag branch from 54011f0 to f5e30c7 Compare March 5, 2024 15:19
Copy link
Contributor

@smelc smelc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirm it fixes the tasty pattern with PARALLEL_TESTNETS=1 and also the change to cardano-testnet-test.hs is sound 👍

@carbolymer carbolymer added this pull request to the merge queue Mar 5, 2024
Merged via the queue into master with commit 1bc4e0c Mar 5, 2024
22 checks passed
@carbolymer carbolymer deleted the mgalazyn/test/expose-parallel-testnet-flag branch March 5, 2024 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants