testnet: fix that custom genesis files were not passed to create-testnet-data #5722
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smelc
force-pushed
the
smelc/testnet-forward-custom-genesis-to-create-testnet-data
branch
2 times, most recently
from
b018e78 to
37c2d12
Compare
smelc
force-pushed
the
smelc/testnet-forward-custom-genesis-to-create-testnet-data
branch
from
37c2d12 to
14fcef5
Compare
newhoggy
approved these changes
Mar 20, 2024
carbolymer
approved these changes
Mar 21, 2024
carbolymer
deleted the
smelc/testnet-forward-custom-genesis-to-create-testnet-data
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Custom genesis files passed to
cardanoTestnetwere not forwarded tocreateSPOGenesisAndFiles(they were only used to alter templatespecfiles), making custom genesis files unusable in practice. This PR fixes this.In addition, this PR improves the handling of the
genesis.era.jsonpaths, by removing the hardcoding of those paths and using functions parameterized byCardanoErainstead.Checklist