Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tx fee check to hprop_transaction #5747

Merged
merged 1 commit into from
Apr 4, 2024
Merged

Conversation

Jimbo4350
Copy link
Contributor

Description

Add your description here, if it fixes a particular issue please provide a
link
to the issue.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. These may include:
    • golden tests
    • property tests
    • roundtrip tests
    • integration tests
      See Runnings tests for more details
  • Any changes are noted in the CHANGELOG.md for affected package
  • The version bounds in .cabal files are updated
  • CI passes. See note on CI. The following CI checks are required:
    • Code is linted with hlint. See .github/workflows/check-hlint.yml to get the hlint version
    • Code is formatted with stylish-haskell. See .github/workflows/stylish-haskell.yml to get the stylish-haskell version
    • Code builds on Linux, MacOS and Windows for ghc-8.10.7 and ghc-9.2.7
  • Self-reviewed the diff

Note on CI

If your PR is from a fork, the necessary CI jobs won't trigger automatically for security reasons.
You will need to get someone with write privileges. Please contact IOG node developers to do this
for you.

@Jimbo4350 Jimbo4350 requested a review from a team as a code owner April 3, 2024 19:03
@Jimbo4350 Jimbo4350 enabled auto-merge April 4, 2024 12:14
@Jimbo4350 Jimbo4350 added this pull request to the merge queue Apr 4, 2024
@Jimbo4350 Jimbo4350 removed this pull request from the merge queue due to a manual request Apr 4, 2024
@Jimbo4350 Jimbo4350 merged commit fbcf101 into master Apr 4, 2024
22 of 23 checks passed
@Jimbo4350 Jimbo4350 deleted the jordan/add-tx-fee-check branch April 4, 2024 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants