Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename new 'can_forge_blocks' metric to 'forging_enabled' #5802

Merged
merged 1 commit into from
Apr 24, 2024
Merged

Rename new 'can_forge_blocks' metric to 'forging_enabled' #5802

merged 1 commit into from
Apr 24, 2024

Conversation

jutaro
Copy link
Contributor

@jutaro jutaro commented Apr 24, 2024 •
edited by mgmeier
Loading

Rename 'can_forge_blocks' to 'forging_enabled'

@jutaro jutaro requested a review from a team as a code owner April 24, 2024 09:58
@jutaro jutaro self-assigned this Apr 24, 2024
@jutaro jutaro requested a review from mgmeier April 24, 2024 09:58
@jutaro jutaro changed the title Rename block forging metrics Rename 'can_forge_blocks' to 'forgingEnabled' Apr 24, 2024
@mgmeier mgmeier changed the title Rename 'can_forge_blocks' to 'forgingEnabled' Rename 'can_forge_blocks' to 'forging_enabled' Apr 24, 2024
@mgmeier mgmeier changed the title Rename 'can_forge_blocks' to 'forging_enabled' Rename new 'can_forge_blocks' metric to 'forging_enabled' Apr 24, 2024
@mgmeier mgmeier force-pushed the jutaro/rename_metric branch from 1e17d4c to daefc74 Compare April 24, 2024 11:43
mgmeier
mgmeier approved these changes Apr 24, 2024
View reviewed changes
Copy link
Contributor

@mgmeier mgmeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking care of this quickly @jutaro

@mgmeier mgmeier enabled auto-merge April 24, 2024 12:38
@disassembler disassembler disabled auto-merge April 24, 2024 18:27
@disassembler disassembler merged commit 6526694 into master Apr 24, 2024
32 of 35 checks passed
@disassembler disassembler deleted the jutaro/rename_metric branch April 24, 2024 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@disassembler disassembler disassembler approved these changes

@mgmeier mgmeier mgmeier approved these changes

Assignees

@jutaro jutaro

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jutaro @disassembler @mgmeier