Skip to content

Conversation

wenkokke
Copy link
Collaborator

This PR renames the TableNotCompatbleError to TableUnionNotCompatibleError and adds more information.

@wenkokke
Copy link
Collaborator Author

@jeltsch You might be well-placed to review this as well, since it's roughly the changes you requested when reviewing the Simple API.

@jeltsch
Copy link
Collaborator

jeltsch commented Mar 29, 2025

I think that I can have a look some time during the next days.

Copy link
Collaborator

@jorisdral jorisdral left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@wenkokke wenkokke force-pushed the wenkokke/table-union-not-compatible branch from ba97bda to ff532df Compare March 31, 2025 13:34
@wenkokke wenkokke force-pushed the wenkokke/table-union-not-compatible branch from ff532df to 93384cc Compare March 31, 2025 14:53
@wenkokke wenkokke enabled auto-merge March 31, 2025 14:53
@wenkokke wenkokke added this pull request to the merge queue Mar 31, 2025
Merged via the queue into main with commit 68487e4 Mar 31, 2025
27 checks passed
@wenkokke wenkokke deleted the wenkokke/table-union-not-compatible branch March 31, 2025 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants