Switch over to the new LedgerDB API #815
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 5, 2023
jorisdral
force-pushed
the
jdral/ledgerdb2-switch
branch
from
9f5a80e to
6db160d
Compare
jorisdral
added a commit
that referenced
this pull request
Dec 13, 2023
# Description Follow-up to #510 This PR includes changes to the alternative LedgerDB API that are required for integration, which is happening in #815. These changes include: * LedgerDB API changes: * The LedgerDB can now be closed * The LedgerDB API now exposes `getToplevelConfig` * Forker acquisition is refactored because we now have three variants instead of two, and we can't reuse `StaticEither` * Remove the STM function argument from forker acquisition * Forker acquisition now requires passing in a resource registry * Moved `QueryBatchSize` to the API level, because it's not implementation specific * Forkers now have a `forkerRangeReadTablesDefault` function that uses a `QueryBatchSize` that is configured for the whole LedgerDB. * `AnnLedgerError` now holds a `Forker`. * Added a few helper functions * V1 implementation: * Export more definitions from the `Snapshots` module * Refactored resource acquisition for backing store handles and db changelogs * Forkers are no longer implemented as separate handles, but stored directly in the `LedgerDBEnv`. This ensures better concurrency behaviour with respect to closing the LedgerDB and closing forkers. Note: forkers are now implemented similar to ChainDB followers. * Expose `LedgerDbSerialiseConstraints` * Small renamings/refactorings
jorisdral
force-pushed
the
jdral/ledgerdb2-switch
branch
2 times, most recently
from
20149b4 to
30d4e25
Compare
jorisdral
force-pushed
the
jdral/ledgerdb2-switch
branch
3 times, most recently
from
c85fdc2 to
4a927f5
Compare
Non-integrated parts: * db-analyser * ChainDB arguments and initialisation * LedgerDB OnDisk QSM tests: LedgerDB initialisation and new commands * LocalStateQuery server tests: LedgerDB initialisation * ChainDB QSM tests: LedgerDB initialisation and new commands Other TODOs: * Use InnerOpenCont for LedgerDB initialisation * Put the BackingStore in a resource registry on LedgerDB initialisation * Move tests into the correct module hierarchy * Remove/tweak the `Show Forker` instance
jorisdral
force-pushed
the
jdral/ledgerdb2-switch
branch
from
4a927f5 to
4a7deb2
Compare
jorisdral
force-pushed
the
jdral/ledgerdb2-switch
branch
2 times, most recently
from
a2430f1 to
c657bcc
Compare
This was referenced Jan 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please include a meaningful description of the PR and link the relevant issues
this PR might resolve.