Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement LDB V2 #858

Merged
merged 6 commits into from
Feb 22, 2024
Merged

Implement LDB V2 #858

merged 6 commits into from
Feb 22, 2024

Conversation

jasagredo
Copy link
Contributor

Description

Please include a meaningful description of the PR and link the relevant issues
this PR might resolve.

@jasagredo
Copy link
Contributor Author

jasagredo commented Dec 29, 2023 •
edited
Loading

This is the new organization

image

jorisdral
jorisdral reviewed Jan 4, 2024
View reviewed changes
Copy link
Contributor

@jorisdral jorisdral left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some early comments

ouroboros-consensus/src/ouroboros-consensus/Ouroboros/Consensus/Storage/LedgerDB/V2/InMemory.hs Outdated Show resolved Hide resolved
...boros-consensus/src/ouroboros-consensus/Ouroboros/Consensus/Storage/LedgerDB/V2/LedgerSeq.hs Outdated Show resolved Hide resolved
...boros-consensus/src/ouroboros-consensus/Ouroboros/Consensus/Storage/LedgerDB/V2/LedgerSeq.hs Outdated Show resolved Hide resolved
ouroboros-consensus/src/ouroboros-consensus/Ouroboros/Consensus/Storage/LedgerDB/V2/Common.hs Outdated Show resolved Hide resolved
...boros-consensus/src/ouroboros-consensus/Ouroboros/Consensus/Storage/LedgerDB/V2/LedgerSeq.hs Outdated Show resolved Hide resolved
ouroboros-consensus/src/ouroboros-consensus/Ouroboros/Consensus/Storage/LedgerDB/V2/Common.hs Outdated Show resolved Hide resolved
ouroboros-consensus/src/ouroboros-consensus/Ouroboros/Consensus/Storage/LedgerDB/V2/Common.hs Outdated Show resolved Hide resolved
ouroboros-consensus/src/ouroboros-consensus/Ouroboros/Consensus/Storage/LedgerDB/Snapshots.hs Outdated Show resolved Hide resolved
ouroboros-consensus/src/ouroboros-consensus/Ouroboros/Consensus/Storage/LedgerDB.hs Outdated Show resolved Hide resolved
ouroboros-consensus/src/ouroboros-consensus/Ouroboros/Consensus/Storage/LedgerDB/API.hs Outdated Show resolved Hide resolved
@jasagredo jasagredo force-pushed the js/implement-ldb-v2 branch 4 times, most recently from b33bf50 to cf74ae8 Compare January 8, 2024 12:59
@jasagredo jasagredo self-assigned this Jan 9, 2024
@jasagredo jasagredo force-pushed the js/implement-ldb-v2 branch 3 times, most recently from a41f92a to ecd30f3 Compare January 12, 2024 14:30
@jasagredo jasagredo force-pushed the js/implement-ldb-v2 branch 2 times, most recently from 7f336d9 to d6c2619 Compare January 22, 2024 12:45
jasagredo
jasagredo commented Jan 23, 2024
View reviewed changes
ouroboros-consensus/src/ouroboros-consensus/Ouroboros/Consensus/Storage/ChainDB/Impl.hs Outdated Show resolved Hide resolved
ouroboros-consensus/src/ouroboros-consensus/Ouroboros/Consensus/Storage/ChainDB/Impl/Types.hs Show resolved Hide resolved
ouroboros-consensus/src/ouroboros-consensus/Ouroboros/Consensus/Storage/ChainDB/Impl/Types.hs Show resolved Hide resolved
ouroboros-consensus/src/ouroboros-consensus/Ouroboros/Consensus/Storage/ChainDB/Impl/Types.hs Show resolved Hide resolved
ouroboros-consensus/src/ouroboros-consensus/Ouroboros/Consensus/Storage/ImmutableDB/Impl.hs Show resolved Hide resolved
ouroboros-consensus/src/ouroboros-consensus/Ouroboros/Consensus/Storage/LedgerDB/V2/Common.hs Outdated Show resolved Hide resolved
ouroboros-consensus/src/ouroboros-consensus/Ouroboros/Consensus/Storage/LedgerDB/V2/InMemory.hs Outdated Show resolved Hide resolved
ouroboros-consensus/src/ouroboros-consensus/Ouroboros/Consensus/Storage/LedgerDB/V2/Init.hs Outdated Show resolved Hide resolved
ouroboros-consensus/src/ouroboros-consensus/Ouroboros/Consensus/Storage/LedgerDB/V2/Init.hs Outdated Show resolved Hide resolved
...boros-consensus/src/ouroboros-consensus/Ouroboros/Consensus/Storage/LedgerDB/V2/LedgerSeq.hs Outdated Show resolved Hide resolved
This was referenced Jan 24, 2024
Closed
Closed
@jasagredo jasagredo force-pushed the js/implement-ldb-v2 branch 6 times, most recently from d4955fc to 24551b3 Compare January 30, 2024 15:49
@jasagredo jasagredo marked this pull request as ready for review January 30, 2024 15:49
@jasagredo jasagredo force-pushed the js/implement-ldb-v2 branch from 24551b3 to b513c20 Compare January 30, 2024 16:07
jasagredo
jasagredo commented Feb 1, 2024
View reviewed changes
ouroboros-consensus/src/ouroboros-consensus/Ouroboros/Consensus/Storage/LedgerDB/API.hs Outdated Show resolved Hide resolved
ouroboros-consensus/src/ouroboros-consensus/Ouroboros/Consensus/Storage/LedgerDB/Impl/Args.hs Outdated Show resolved Hide resolved
...oros-consensus/src/ouroboros-consensus/Ouroboros/Consensus/Storage/LedgerDB/Impl/Validate.hs Show resolved Hide resolved
ouroboros-consensus/src/ouroboros-consensus/Ouroboros/Consensus/Storage/LedgerDB/Impl/Init.hs Outdated Show resolved Hide resolved
ouroboros-consensus/src/ouroboros-consensus/Ouroboros/Consensus/Storage/LedgerDB/Impl/Init.hs Outdated Show resolved Hide resolved
ouroboros-consensus/src/ouroboros-consensus/Ouroboros/Consensus/Storage/LedgerDB/V1/Common.hs Outdated Show resolved Hide resolved
ouroboros-consensus/src/ouroboros-consensus/Ouroboros/Consensus/Storage/LedgerDB/V1/Common.hs Outdated Show resolved Hide resolved
ouroboros-consensus/src/ouroboros-consensus/Ouroboros/Consensus/Storage/LedgerDB/V2/Common.hs Outdated Show resolved Hide resolved
ouroboros-consensus/src/ouroboros-consensus/Ouroboros/Consensus/Storage/LedgerDB/V2/Common.hs Outdated Show resolved Hide resolved
ouroboros-consensus/src/ouroboros-consensus/Ouroboros/Consensus/Storage/LedgerDB/V2/Common.hs Outdated Show resolved Hide resolved
@jasagredo jasagredo force-pushed the js/implement-ldb-v2 branch from b513c20 to 7d95413 Compare February 1, 2024 12:21
@jasagredo jasagredo force-pushed the js/implement-ldb-v2 branch 2 times, most recently from ed6dd2c to fc1c249 Compare February 19, 2024 12:21
@jasagredo jasagredo mentioned this pull request Feb 19, 2024
Closed
Base automatically changed from jdral/ledgerdb2-switch to utxo-hd-8.2.1 February 22, 2024 14:42
@jasagredo
Small .cabal changes and other trifles
0d4f2d8 
- Remove `backingStoreTracer`
- Define `(en|de)codeExtLedgerState'`
- Define `[In]Complete` aliases
@jasagredo
Relocate definitions in LedgerDB.(API|Impl)
286e05e
@jasagredo
Rework ChainDBArgs and initialization in run
2e58e5c
@jasagredo
Performance improvements
457d80f 
- Avoid using indices when decoding txouts
- Strictly decode `ValuesMK`
@jasagredo
Rework LedgerDB V1
f57f8d3 
- Use `readLocked` and `writeLocked`
- Initialize via `InitDB`
- Rework `BackingStoreSelector` into `BackingStoreArgs`
@jasagredo
Implement LedgerDB V2
9f0ad59
@jasagredo jasagredo merged commit 4eab6eb into utxo-hd-8.2.1 Feb 22, 2024
0 of 3 checks passed
@jasagredo jasagredo deleted the js/implement-ldb-v2 branch February 22, 2024 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jorisdral jorisdral jorisdral left review comments

Assignees

@jasagredo jasagredo

Labels
UTxO-HD
Projects
Consensus Team Backlog
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jasagredo @jorisdral