-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Praos: use larger nonce stabilization window starting in Conway #927
Conversation
2d845d3
to
e3f2dea
Compare
Note: We should also inform other teams about this change; in particular such that |
a90ce75
to
0f1654c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. The glossary also is understandable.
We should not merge this for the Consensus release that goes into node 8.9 as that release it supposed to be rather minimal (and this PR requires all existing Conway chains to be truncated, in particular Sanchonet). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
...ros-consensus-protocol/changelog.d/20240206_174209_alexander.esgen_change_epoch_structure.md
Outdated
Show resolved
Hide resolved
ouroboros-consensus-cardano/src/ouroboros-consensus-cardano/Ouroboros/Consensus/Cardano/Node.hs
Show resolved
Hide resolved
It was unused, and there also isn't really a motivation why we might want to "translate" `ConsensusConfig`s.
0f1654c
to
d20248c
Compare
Merging now as the Consensus packages for Node 8.9 were released in #969. (Context: #927 (comment)) |
🎉 |
Closes #297, closes IntersectMBO/cardano-ledger#2478, closes IntersectMBO/cardano-ledger#1914
See erratum 17.3 (amended in IntersectMBO/cardano-ledger#4015) in the Shelley ledger specs for context.