Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Praos: use larger nonce stabilization window starting in Conway #927

Merged
merged 3 commits into from Feb 26, 2024

Conversation

amesgen
Copy link
Member

@amesgen amesgen commented Jan 26, 2024

Closes #297, closes IntersectMBO/cardano-ledger#2478, closes IntersectMBO/cardano-ledger#1914

See erratum 17.3 (amended in IntersectMBO/cardano-ledger#4015) in the Shelley ledger specs for context.

@amesgen
Copy link
Member Author

amesgen commented Feb 6, 2024

Note: We should also inform other teams about this change; in particular such that cardano-cli commands reporting the leader schedule can be adapted (as they have to implement the logic themselves until something like #390 lands).

@amesgen amesgen marked this pull request as ready for review February 6, 2024 17:09
@amesgen amesgen requested a review from a team as a code owner February 6, 2024 17:09
@amesgen amesgen force-pushed the amesgen/change-epoch-structure branch from a90ce75 to 0f1654c Compare February 6, 2024 17:15
Copy link
Contributor

@jasagredo jasagredo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. The glossary also is understandable.

@amesgen
Copy link
Member Author

amesgen commented Feb 8, 2024

We should not merge this for the Consensus release that goes into node 8.9 as that release it supposed to be rather minimal (and this PR requires all existing Conway chains to be truncated, in particular Sanchonet).

Copy link
Contributor

@nfrisby nfrisby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

It was unused, and there also isn't really a motivation why we might want to
"translate" `ConsensusConfig`s.
@amesgen amesgen force-pushed the amesgen/change-epoch-structure branch from 0f1654c to d20248c Compare February 26, 2024 14:33
@amesgen
Copy link
Member Author

amesgen commented Feb 26, 2024

Merging now as the Consensus packages for Node 8.9 were released in #969. (Context: #927 (comment))

@amesgen amesgen added this pull request to the merge queue Feb 26, 2024
Merged via the queue into main with commit af4b27e Feb 26, 2024
15 checks passed
@amesgen amesgen deleted the amesgen/change-epoch-structure branch February 26, 2024 15:39
@JaredCorduan
Copy link
Contributor

🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
4 participants