Update DiskPolicyArgs with StdRunNodeArgs #985
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The value read from the configuration was passed in the StdRunNodeArgs but it was not set in the ChainDB args which later on configure the LedgerDB.
RenateEilers
approved these changes
Mar 6, 2024
dnadales
approved these changes
Mar 6, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Mar 26, 2024
The problem fixed by #985 was caused by a new field not being used as it was only bound by `RecordWildCards`, which does not warn when some of the fields are unused. This PR introduces the [`safe-wild-cards` library][safe-wild-cards] which is exactly about addressing this problem. There are some concerns about this: - `TemplateHaskell` is known to sometimes have a negative effect on recompilation avoidance, and is generally annoying with cross compilation (however, we already use TH in tests, and eg cardano-node also uses it in the "main" code, so that isn't a show stopper). - `TemplateHaskell` has the weird stage restriction, which makes it necessary to shuffle some things around here. See the [*Note* at the bottom][safe-wild-cards] for an explanation why this is necessary. Potential alternatives include: - (lightweight but more tedious) Use a more manual approach to avoid forgetting to handle fields (eg also pattern-matching on the bare constructor `StdRunNodeArgs _ _ _ ... = ...`). - (heavyweight) Refactor our configuration code to use some record library, such that the logic for passing down configuration values is "automatic" instead of requiring sth like `updateChainDbDefaults` in the current code. - Wait until [this GHC proposal](https://github.com/brandon-leapyear/ghc-proposals/blob/patch-1/proposals/0436-recordwildcards-total.rst) has been implemented. [safe-wild-cards]: https://hackage.haskell.org/package/safe-wild-cards-1.0.0.1/docs/SafeWildCards.html#v:fields
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The value read from the configuration was passed in the StdRunNodeArgs but it was not set in the ChainDB args which later on configure the LedgerDB.