Move functionality of calculating big ledger peers to ouroboros-network-api #4849
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crocodile-dentist
force-pushed
the
mwojtowicz/expose-accBigPoolStake-network-api
branch
5 times, most recently
from
b8d18a2 to
28da25c
Compare
coot
reviewed
Apr 18, 2024
ouroboros-network-api/src/Ouroboros/Network/PeerSelection/LedgerPeers/Util.hs
Outdated
Show resolved
Hide resolved
ouroboros-network-api/src/Ouroboros/Network/PeerSelection/LedgerPeers/Util.hs
Outdated
Show resolved
Hide resolved
crocodile-dentist
force-pushed
the
mwojtowicz/expose-accBigPoolStake-network-api
branch
from
28da25c to
515adb5
Compare
|
There are some build failures on CI. |
crocodile-dentist
force-pushed
the
mwojtowicz/expose-accBigPoolStake-network-api
branch
from
515adb5 to
088d1e8
Compare
crocodile-dentist
force-pushed
the
mwojtowicz/expose-accBigPoolStake-network-api
branch
from
088d1e8 to
ced1571
Compare
bolt12
approved these changes
May 22, 2024
crocodile-dentist
force-pushed
the
mwojtowicz/expose-accBigPoolStake-network-api
branch
2 times, most recently
from
60d9b62 to
ddafa5b
Compare
|
Tests found a bug, but it is on master as well which makes sense as this PR and the one before are pretty much administrative changes. [edit] To reproduce, run: cabal run ouroboros-network:sim-tests -- --quickcheck-replay=53448 -p '/progress.ledger peers.progresses towards established target (from below)/ |
Moved utility functions to ouroboros-network-api to support calculating big ledger peer snapshots by upstream libraries, for eg. Genesis consensus mode and bootstrapping a node with a recent snapshot of these peers.
crocodile-dentist
force-pushed
the
mwojtowicz/expose-accBigPoolStake-network-api
branch
from
3c32cda to
d2eaf3b
Compare
crocodile-dentist
deleted the
mwojtowicz/expose-accBigPoolStake-network-api
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This functionality is leveraged by downstream libraries to serialize a snapshot of big ledger peers in support of Genesis consensus mode.
Checklist