Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nix: updated tools #4860

Merged
merged 4 commits into from
Apr 25, 2024
Merged

nix: updated tools #4860

merged 4 commits into from
Apr 25, 2024

Conversation

coot
Copy link
Contributor

@coot coot commented Apr 24, 2024 •
edited
Loading

Description

Updated tools used by nix.

Checklist

  • Branch
    • Updated changelog files.
    • Commit sequence broadly makes sense
    • Commits have useful messages
    • The documentation has been properly updated
    • New tests are added if needed and existing tests are updated
    • If serialization changes, user-facing consequences (e.g. replay from genesis) are confirmed to be intentional.
  • Pull Request
    • Self-reviewed the diff
    • Useful pull request description at least containing the following information:
      • What does this PR change?
      • Why these changes were needed?
      • How does this affect downstream repositories and/or end-users?
      • Which ticket does this PR close (if any)? If it does, is it linked?
    • Reviewer requested

@coot
nix: upgraded nix.lock, ghc and tools
72ab43c 
ghc: 9.6.3 -> 9.8.2
cabal: 3.10.3.0
ghcid: 0.8.9
hls: 2.7.0.0
@coot coot requested review from a team as code owners April 24, 2024 18:54
@coot coot self-assigned this Apr 24, 2024
@coot coot added nix This includes CI, nix changes or cabal dependencies CI Issues / PRs related to CI labels Apr 24, 2024
@coot coot enabled auto-merge April 24, 2024 18:57
coot added 3 commits April 25, 2024 09:59
@coot
outbound-governor: fixed a bootstrap peer test
f34bb46 
Fixed the `prop_governor_only_bootstrap_peers_in_clean_state` test.

Clean state is a state in which we are required to use bootstrap peers:
the outbound governor enters clean state as soon as
* `requiresBootstrapPeers` returns `True`; and
* it only uses bootstrap peers.
It leaves the clean state when `requiresBootstrapPeers` changes value to
`False`.

It turns out we also need to get known and trusted peers as a single
event, otherwise they might get out of sync which results in a false
positive.
@coot
outbound-governor: fixed shrinking of local root peers
f61f0df
@coot
outbound-governor: improved shrinking of GovernorMockEnvironment
fbe5de4
@coot coot force-pushed the coot/flake.nix-update-tools branch from c4efb54 to fbe5de4 Compare April 25, 2024 08:05
@coot coot added this pull request to the merge queue Apr 25, 2024
@coot coot removed this pull request from the merge queue due to a manual request Apr 25, 2024
@crocodile-dentist
Copy link
Contributor

LGTM

@coot coot added this pull request to the merge queue Apr 25, 2024
Merged via the queue into master with commit 204cba0 Apr 25, 2024
12 of 13 checks passed
@coot coot deleted the coot/flake.nix-update-tools branch April 25, 2024 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@disassembler disassembler disassembler approved these changes

@crocodile-dentist crocodile-dentist crocodile-dentist approved these changes

Assignees

@coot coot

Labels
CI Issues / PRs related to CI nix This includes CI, nix changes or cabal dependencies
Projects
Ouroboros Network
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@coot @crocodile-dentist @disassembler