inbound governor error handling #4871
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coot
force-pushed
the
coot/inbound-governor-patch
branch
3 times, most recently
from
e54c476 to
3b5d365
Compare
bolt12
approved these changes
May 7, 2024
The inbound governor error handler is there only to show final transitions, mostly for testing purposes. We can pass the map of remote states through `PublicInboundGovernorState` rather than hold whole `InboundGovernorState` in a mutable variable. This allows the main loop of inbound governor to have access to the `InboudnGovernorState` directly as an argument, making it clearer how it can be used.
coot
force-pushed
the
coot/inbound-governor-patch
branch
from
3b5d365 to
2416f75
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
inbound-governor: error handling
The inbound governor error handler is there only to show final
transitions, mostly for testing purposes. We can pass the map of remote
states through
PublicInboundGovernorStaterather than hold wholeInboundGovernorStatein a mutable variable.This allows the main loop of inbound governor to have access to the
InboudnGovernorStatedirectly as an argument, making it clearer how itcan be used.
The PR should be merged after #4868, only the last commit matters.
Checklist
Quality
Maintenance
ouroboros-networkproject.