Skip to content

Fix/binding resolution #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 25, 2025
Merged

Fix/binding resolution #19

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
30c4b64
Add missing dependencies
olivervogel Feb 25, 2025
7ad47ab
Change http response instantiation
olivervogel Feb 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,8 @@
"require": {
"php": "^8.1",
"illuminate/support": "^8|^9|^10|^11|^12",
"illuminate/http": "^8|^9|^10|^11|^12",
"illuminate/routing": "^8|^9|^10|^11|^12",
"intervention/image": "^3.11"
},
"require-dev": {
Expand Down
3 changes: 1 addition & 2 deletions src/ImageResponseFactory.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@
namespace Intervention\Image\Laravel;

use Illuminate\Http\Response;
use Illuminate\Support\Facades\Response as ResponseFactory;
use Intervention\Image\Exceptions\DriverException;
use Intervention\Image\Exceptions\NotSupportedException;
use Intervention\Image\Exceptions\RuntimeException;
Expand Down Expand Up @@ -68,7 +67,7 @@ public static function make(
*/
public function response(): Response
{
return ResponseFactory::make(
return new Response(
content: $this->content(),
headers: $this->headers()
);
Expand Down
7 changes: 2 additions & 5 deletions tests/ImageResponseFactoryTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,13 +12,10 @@
use Intervention\Image\ImageManager;
use Intervention\Image\Laravel\ImageResponseFactory;
use Intervention\Image\MediaType;
use Orchestra\Testbench\Concerns\WithWorkbench;
use Orchestra\Testbench\TestCase as TestBenchTestCase;
use PHPUnit\Framework\TestCase;

class ImageResponseFactoryTest extends TestBenchTestCase
class ImageResponseFactoryTest extends TestCase
{
use WithWorkbench;

protected Image $image;

protected function setUp(): void
Expand Down