2001/no jira passion logger with context #12
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Feb 18, 2020
ColinDKelley
commented
Feb 18, 2020
houndci-bot
reviewed
Feb 18, 2020
ColinDKelley
force-pushed
the
2001/no-jira-passion-logger-with-context
branch
from
20c165b to
24df4fb
Compare
jebentier
requested changes
Feb 18, 2020
…legate to logger for level
houndci-bot
reviewed
Feb 18, 2020
jebentier
approved these changes
Feb 24, 2020
houndci-bot
reviewed
Feb 24, 2020
houndci-bot
reviewed
Feb 24, 2020
|
|
||
| it "merges context" do | ||
| subject.fatal("fatal message", call_id: "234-123") | ||
| expect(log_stream.string).to match(/\{"message":"fatal message","severity":"FATAL","timestamp":".*","log_source":"redis_client","call_id":"234-123"\}/) |
There was a problem hiding this comment.
Metrics/LineLength: Line is too long. [157/150]
|
@jebentier The contract change I mentioned on the screen share: 13bd8dd?utf8=%E2%9C%93&diff=split&w=1 |
houndci-bot
reviewed
Feb 25, 2020
| require 'rubygems' | ||
| require 'bundler/setup' | ||
|
|
||
|
|
There was a problem hiding this comment.
Layout/EmptyLines: Extra blank line detected.
| @@ -0,0 +1,14 @@ | |||
| #!/usr/bin/env rake | |||
There was a problem hiding this comment.
Lint/ScriptPermission: Script file Rakefile doesn't have execute permission.
houndci-bot
reviewed
Feb 27, 2020
|
@jebentier Can you please review the changes I just pushed? |
jebentier
approved these changes
Feb 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces new
LoggerWithContextclass. Example usage:Now the redis_client gem will be logging at the DEBUG level (regardless of
logger's level) and all its log messages will be tagged withlog_source = redis_client. With no changes required to theredis_clientgem! :)Factory shorthand for the above that snaps to the logger's
level:LoggerMixinthat implements theleveland thedebug,info...fatalmethods so those can be used in both places.