Skip to content

Extract normalize_log_level #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Mar 6, 2020
Merged

Extract normalize_log_level #13

merged 4 commits into from
Mar 6, 2020

Conversation

ColinDKelley
Copy link
Contributor

Summary of Changes

  • Extract normalize_log_level to the ContextualLogger level so we can call it elsewhere.

@ColinDKelley ColinDKelley requested a review from nburwell March 6, 2020 19:35
houndci-bot
houndci-bot reviewed Mar 6, 2020
View reviewed changes
@ColinDKelley ColinDKelley changed the title Extract normalize log level Extract normalize_log_level Mar 6, 2020
nburwell
nburwell approved these changes Mar 6, 2020
View reviewed changes
Copy link
Contributor

@nburwell nburwell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ColinDKelley ColinDKelley merged commit 2fdf3c0 into master Mar 6, 2020
@ColinDKelley ColinDKelley deleted the extract-normalize_log_level branch March 6, 2020 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nburwell nburwell nburwell approved these changes

+1 more reviewer

@houndci-bot houndci-bot houndci-bot left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ColinDKelley @nburwell @houndci-bot