Skip to content

Removing hardcoded ruby version from .travis.yml #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 19, 2020
Merged

Removing hardcoded ruby version from .travis.yml #32

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions .travis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,4 @@
language: ruby
rvm:
- 2.4.5
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you set the .ruby-version file to this version of ruby to keep testing against the same version?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, we want to keep it at 2.4.5? If so, we need to nail down the dependency on activesupport then, as it will need 2.5+ (and right now there is no max dependency requirement there).

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh wait I see better what’s going on here. We should test across multiple versions of ruby and active support here. Not just completely remove the rvm. Could you build out the ruby/active support matrix that’s necessary for travis?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't forgotten about this..

I understand how to get multiple ruby versions tested, and assume would follow this for active support versions (i.e. use Appraisal) but will likely need help on how to get the matrix to omit older ruby versions for newer active support versions?

Also before further work here, would like to touch base with you on what the vision is for open source repos in regards to what gets run where.. since Jenkins is running the tests across the 3 appraisal versions today (and ideally without much duplication).

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here is a PR off of yours that sets this up with the full matrix of multiple ruby versions and appraisal. #33

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. So for open source where we are running on travis, do we still want to also run the N stages of tests on Jenkins? Is jenkins still going to be the source of truth for adding the clean-build tag?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, I don't think Jenkins should be used at all because it's not public and won't ever be public. TravisCI should be the source of truth for green builds of our public gems/projects imo.

dist: trusty
install:
- bundle install --jobs=3 --retry=3
Expand Down